Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testnet #7

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Testnet #7

merged 4 commits into from
Mar 6, 2024

Conversation

jbcaron
Copy link
Member

@jbcaron jbcaron commented Mar 6, 2024

Pull Request type

  • Feature
  • Refactoring (no functional changes, no API changes)

What is the current behavior?

What is the new behavior?

  • using a RwLock to allow for concurrent reads and exclusive writes instead of Mutex
  • removal of Arc not necessary for lazy_static
  • registration of the L1 contract in the config for Sepolia sync according to user parameters

Does this introduce a breaking change?

No

Other information

Removing hardcoded mainnet specific variables by using a lazy static to store the configuration, refactoring of the lazy statics
@jbcaron jbcaron requested a review from Tbelleng March 6, 2024 11:13
@jbcaron jbcaron self-assigned this Mar 6, 2024
@antiyro antiyro merged commit cd75088 into madara-alliance:main Mar 6, 2024
6 checks passed
@jbcaron jbcaron deleted the testnet branch May 3, 2024 12:37
Mohiiit pushed a commit that referenced this pull request Oct 19, 2024
* feat(exex_behavior):

* feat(exex_behavior): Updated addresses

* feat(exex_behavior):

* feat(exex_behavior): Better logs

* feat(exex_behavior): quick refacto

* feat(exex_behavior):

* feat(exex_behavior): Refactoring

* feat(exex_behavior): Better logs

* feat(exex_behavior): reliable arg order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants