Added boilerplate for Bonsai storage migration #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
April 10, 2024 17:03
Bonsai trie handlers no longer access the db at a given state and instead only serve to view or mutate the latest state.
`get_at` functions similarly to calling `storage_handler::storage_at().get()` but is faster since it only reverts the state for a given key.
jbcaron
approved these changes
Apr 22, 2024
Trantorian1
force-pushed
the
feat/storage
branch
from
d82a3c4
to
839e981
Compare
Trantorian1
force-pushed
the
feat/storage
branch
from
9261db0
to
ef711d1
Compare
added 5 commits
April 23, 2024 01:00
added 3 commits
April 23, 2024 13:51
antiyro
approved these changes
Apr 24, 2024
jbcaron
approved these changes
Apr 24, 2024
| Ok(Some(block_number)) => block_number, | ||
| _ => get_highest_block_hash_and_number().1, | ||
| }, | ||
| BlockId::Tag(_) => get_highest_block_hash_and_number().1, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
Currently, Deoxys relies heavily on the Substrate runtime storage. This poses issues as it was designed for sparse usage, and is not pertinent for the storage of data which is not consensus-critical. Furthermore, use of the Substrate runtime storage and the associated
StorageOverrides built on top has lead to a convoluted use of storage which is hard to reason about.What is the new behavior?
crates/client/src/storage_handlerfor accessing storage statically and outside of the Substrate runtime.BonsaiStorageandRevertibleStorageviastorage_handler. This inculdes the following mappings:block_number->block_hashblock_hash->block_numbercontract_address->class_hash&nonceclass_hash->contract_abi&contract_classclass_hash->compiled_class_hashon_initializedis no longer used for storing data. Any related logic, such as serializing data to communicate it to the runtime for storage, have been removed. Storage updates are now handled as part ofl2.rs.StorageOverridefrom the code base.Does this introduce a breaking change?
Yes. Any node already running will have to be re-run from the block 0 to update the new databases.
Other information
Note that this is PR mostly introduces the boilerplate necessary for a full migration to Bonsai lib storage. Further improvements remain to be made:
Noncesin the db in some special cases.Please keep these points in mind as you review this PR.