Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nokia phones and codenames.csv #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TechnoStone
Copy link

Sorted alphabetically

@madb1lly
Copy link
Owner

Hi @TechnoStone,
Thanks for your interest in this little project! 😃

Have you added any information, or just changed the order so it's sorted alphabetically?

If you've just changed to sort alphabetically then I won't accept the PR. The list is intentionally sorted according to the TA number because this is the only unique ID in the entire list - it is the key of the database (although it is not a database, strictly). The list can be downloaded and sorted alphabetically in any programme like Calc or Excel, if that is what you want to do.

If you've got more information to contribute then please do raise PRs for this and include a reference to the source of your information in the PR.

Cheers 🙂

@singhnsk
Copy link
Contributor

Hi @TechnoStone, nice to see you here too. Good job on those Nokia 8.1 overlays mate 👍
@madb1lly Maybe maybe this alphabetical sorting makes browsing the data easier. Naturally, more number of users will browse the list based on model numbers and not based on TA codes. Well, yes, I was always required to use find function to look for other variants of the same model, else I'd very easily manage to miss one of them. Having all of them listed together is easier for anybody who is looking for a particular device.
If you wanna keep it TA wise, maybe we can have something which automatically pulls the data into Google sheets or Online excel and sorts it alphabetically and we can include a link to it in the readme? Not sure how to do it, but I'm sure that is possible 😃

@madb1lly
Copy link
Owner

Hi @singhnsk,

Updating the list from sources of information is largely done based on TA number. All the certification databases (Wifi, BLuetooth, GCF, FCC, etc) are based on TA number. Therefore it's much easier to update the table when it's sorted by TA number. Since almost all of the updates to the list are done by me I prefer to save myself time and have it easy to update. Whenever I want to look at info per model name I download the repo and sort the CSV file by model name, just like you have to. I also do this when I'm adding a lot of new changes, like lots of lines for new models where the only difference per line is the TA number. When I've done the changes I then reorder by TA number and commit the new list. However, these big changes are rare.

So, as long as I'm doing the updates I won't be changing the order. However, please feel free to fork the repo and modify the list however you want. When you something I like and then I'll merge your work back into this list.

Your suggestion for automatic export into some online viewer is a nice one, please feel free to look into it and show us when you've got something working, then we can see if it makes sense to change how this list is stored.

For info, the reason I chose to store as CSV is because it's easily viewable on Github. XLS etc can't be viewed in the browser, and an XML or JSON structure would be machine readable but not easily human readable.

Cheers 🙂

@warthog911
Copy link

warthog911 commented Nov 24, 2020

31GMNM4002A (GMN) (prolly nokia 125/150 (2020)
India customs data states: PROTO WITH BATTERY-TA-1235/TA-1253(PARTNO:12GMNB21X01,12GMNB21X01)(PROTO TYPE PHONE FOR TESTING PURPOSE ONLY)
31PISM7000A (PIS) (5310 DS)
31QENM1400A (QEN) (215/225 as QEN basic and QEN value)
https://www.flipkart.com/nokia-225-4g-ds-2020/p/itma0077f660a7f4

31KIGM5000A (KIG)
NKL

Any ideas madbilly?

TA-1059 is ARG aka 8110 4G
rm-1187 is 4YK
ta-1030 is 4ZQ
rm-1190 is 4YW

@warthog911
Copy link

warthog911 commented Oct 13, 2021

any idea for SB0KET1B00A and SB0NES1B00A . Is it 6310 4g
or 110 4g and which one?

@madb1lly
Copy link
Owner

Hi @warthog911,

You're commenting on a pull request, but I think what you're saying is unrelated to it, it would be better if you could raise an issue about these questions rather than comment on this PR. If you have actually have an update to provide then please raise a new PR.

I've not maintained this list for almost a year now and I am unlikely to update it. If you want to take it on then please feel free to fork it and maintain your copy, I'll happily send people in your direction to provide updates.

Cheers 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants