This repository has been archived by the owner on Oct 19, 2023. It is now read-only.
Readdir Implementation - and covering with tests #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'll try to review this soon. |
|
Can you 1) revert the import path changes, 2) squash all these into a single commit or else group them into specific commits? |
|
@mjibson ok - I'll combine all commit's into one |
- [X] Added Readdir - [X] Moved all string manipulations to html/template - [X] Cover embed.go with tests (about 80%) - [X] Cover generated static.go with test (about 80%) 1. htttest for checking FileServer 2. checking both mode - useLocal=false and useLocal=true for the same testcases 3. added benchmark - [X] Added testdata dir with some static files (some html5 template) - [X] Added example folder with http.FileServer and generated from testdata - [x] Added golang.org/x/tools/imports for generated file (like goftm for generated file) - [X] Added to travis `go generate` and go test after it, as `smoke tests`.
|
A couple of months since the last update. I would like this feature. Is it likely to be merged soon? |
|
I didn't carefully review or test this PR, but it looks pretty good so I'm just going to merge it and hope it works. |
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Jan 20, 2020
full diff: maddyblue/esc@v0.1.0...v0.2.0 includes: - maddyblue/esc#51 Readdir Implementation - and covering with tests - maddyblue/esc#53 update go versions and golint import location - maddyblue/esc#58 Avoid unnecessary conversion and so pass with unconvert linter Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Jan 20, 2020
full diff: maddyblue/esc@v0.1.0...v0.2.0 includes: - maddyblue/esc#51 Readdir Implementation - and covering with tests - maddyblue/esc#53 update go versions and golint import location - maddyblue/esc#58 Avoid unnecessary conversion and so pass with unconvert linter Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Jan 27, 2020
full diff: maddyblue/esc@v0.1.0...v0.2.0 includes: - maddyblue/esc#51 Readdir Implementation - and covering with tests - maddyblue/esc#53 update go versions and golint import location - maddyblue/esc#58 Avoid unnecessary conversion and so pass with unconvert linter Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jan 28, 2020
full diff: maddyblue/esc@v0.1.0...v0.2.0 includes: - maddyblue/esc#51 Readdir Implementation - and covering with tests - maddyblue/esc#53 update go versions and golint import location - maddyblue/esc#58 Avoid unnecessary conversion and so pass with unconvert linter Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 97010520d45437f211f88f8d988d6708cbebfc58 Component: cli
eiffel-fl
pushed a commit
to eiffel-fl/cli
that referenced
this pull request
Jul 28, 2020
full diff: maddyblue/esc@v0.1.0...v0.2.0 includes: - maddyblue/esc#51 Readdir Implementation - and covering with tests - maddyblue/esc#53 update go versions and golint import location - maddyblue/esc#58 Avoid unnecessary conversion and so pass with unconvert linter Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go generateand go test after it, assmoke tests.