-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heading Options #104
Comments
This is a great idea and is something we've been toying with. It's also useful as an abstract concept for blocks, the idea of a switcher that can handle multiple states of blocks. Eg a list block handling an ordered and unordered list. Would you be interested in having a go at implementing this? I'm thinking it could be a mixin the block.. |
Using the pull request from #118 this would be fairly trivial to implement. |
@cjbell88 Are you thinking it would use the new controls to create new buttons for h1-h6 versus on the toolbar? |
Totes agree, a state switcher is a lovely idea. I wonder how we ensure people understand that headings are hierarchical though? Last thing we want is the old "I'll choose this h3 thing because I think it looks better than an h1" Maybe that's just a wording/copy issue though! Can we perhaps limit this to h1-3 until a requirement for more levels surfaces? Still stick by the old mantra that if you need to go past a third level of hierarchy, you're probably doing something wrong. Sent from my iPhone
|
@andrewsprinz Good point. Some of the clients I work with would not understand the hierarchy and definitely would pick based on appearance. Maybe just the wording as you mentioned such as (Heading, Sub Heading, Topic?) instead of h1, h2, h3. |
Love those, definitely more human than H1, H2 etc. :) Sent from my iPhone
|
Great shout both. 👍 |
Leaving this open but putting it into a future release milestone. |
Hey guys, if you want to check it out, I did it using formatBlock command. |
Hello guys, I have implemented a heading block for my site. Maybe you have use of it. See gist: https://gist.github.com/marioschubert/683b3c5fc9d1135e7751 |
@marioschubert well done. For my use case I may tweak it slightly and change the numbers to something human like: xlarge, large, small, xsmall... or something like that. I'm fairly new to ST and glad I stumbled on your gist. Perhaps we should see if the rest of the folks want that kept in the custom blocks repo |
@aggied Thank you. Your welcome. :-) @cjbell88 Should I file a pull request for the custom block repo? What has to be done before / therefore? |
I have improved the heading block for my site. The currently selected level is now highlighted. Maybe you have use of it. See gist: https://gist.github.com/marioschubert/683b3c5fc9d1135e7751 In my rails back end I use CSS automatic numbering for the rendered headings. This does not work in editing mode, because of the nested divs. So numbering has to be done by javascript, but I haven't had not enough time for this, yet. |
Extract sanitizer plugin into its own repo
When adding a heading you should be able to change it to h1, h2, h3 (4, 5, 6?) in the formatter controls as well as the existing italic (is bold needed)? A button may be appropriate as well for those that use http://getbootstrap.com/css/#type-headings. Since these buttons are only needed for headings it would still keep the other block type formatter controls simple.
The text was updated successfully, but these errors were encountered: