Added AttachedCommand. #34
Conversation
konrad-kruczynski
force-pushed
the
attached_command
branch
from
80605c3
to
c846465
Compare
|
Thanks @konrad-kruczynski this looks great! Let me know when you've had a chance to take a look at the comments. |
|
This will resolve #30 |
|
I've just pushed changes. They are now there as a separate commit, I can squash it later, but I think it might be easier for you to review changes this way. Also please take a look at yet unresolved comments. I know that I only have "spikes" of activity from time to time, but actually that's all I can do considering available time slots ;) |
There was a problem hiding this comment.
Thanks! I think I've gone through and resolved/updated all the comment threads (I'm not super familiar with the GitHub PR UI so if I missed something just post me a link).
I know that I only have "spikes" of activity from time to time, but actually that's all I can do considering available time slots ;)
Don't worry about it! I really appreciate your help and engagement on this!
|
Frankly speaking I'm not accustomed to the Github PR UI (yet) as well, using it for the second time. Fixed one thing and one is waiting for the answer. |
|
Ok so I think everything is resolved now? Are you comfortable with me merging? |
Yes, at least it seems so :)
Yes, I am. Should I squash the commits into one? |
If you get a chance to do in the next 24 hours or so then go for it. If not, I'll probably just go ahead and merge; I'm not a purist when it comes to git history |
AttachedCommand is the Command used when attaching to already running process.
konrad-kruczynski
force-pushed
the
attached_command
branch
from
6a60645
to
1ccd64f
Compare
|
Done. |
AttachedCommand is the Command used when attaching to already running
process.