Override assembly names loaded through AssemblyResolve handlers when searching currently loaded assemblies.

[vitorhnn]

The program that led me down this rabbit hole is STORY OF SEASONS: A Wonderful Life's launcher. (steam appid 2111170).

It uses an AssemblyResolve handler to load assemblies from its own resources, but it ships a version of System.Threading.Tasks.Extensions that doesn't match the version requested by its assemblies.

Framework handles this by assuming whatever's returned from AssemblyResolve handlers is the requested assembly and caching that for future loads.

Mono doesn't do this and double loads this assembly (due to two of the launcher's dependencies triggering a load), which leads to a failure to setup a vtable due to mismatching types (they're the same type, but loaded from two different instances of the same assembly).

I have a more realistic repro of the issue here. It should build fine by just using msbuild

Not entirely happy with this solution, but the bits of the assembly loader that insert the assembly into MonoDomain::domain_assemblies do not receive the name it was requested under, and passing that in would entail changing parts of Mono's assembly load hooks, which I wasn't comfortable with. Let me know if that would be preferrable and I can try to go for it.

[madewokherd]

Other than the data structure used, I think this is the right approach.

[vitorhnn]

v2: Switched to a HashTable of pointer arrays to deal with assemblies potentially having multiple aliases.

[madewokherd]

I don't really understand the advantage of a hash table at all, given that we must visit all entries when using it. I feel like a list of assembly/name pairs would be more efficient.

[vitorhnn]

Hmm, do you mean something like this?:

mono_domain_assembly_search(...)
{
    ...
    mono_domain_assemblies_lock(domain);
    for (tmp = domain->overriden_names; tmp; tmp->next)
        /* try to match with tmp->aname */
    for (tmp = domain->domain_assemblies; tmp; tmp->next)
        /* same code as current develop */
    mono_domain_assemblies_unlock(domain);
    ...
}

or something more intrusive, like changing domain->domain_assemblies to be a list of aname, assembly pairs?

[madewokherd]

Yep, something like that.

[vitorhnn]

v3: Ditched the hash table

[madewokherd]

Looks good to me, I'll merge it in if the CI doesn't show any problems. (Note: CI will probably fail, don't worry about it, I'll let you know if any of it looks related.)

[madewokherd]

This was released in Wine Mono 8.1.0, which I just pushed to Proton Experimental bleeding-edge.