System.Configuration: User configuration file saving fixes, part 2. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erencesource. Signed-off-by: Connor McAdams <conmanx360@gmail.com>
…n} from referencesource. Signed-off-by: Connor McAdams <conmanx360@gmail.com>
…rce. SettingElement, SettingValueElement, and SettingElementCollection are all contained within ClientSettingsSection in referencesource. Signed-off-by: Connor McAdams <conmanx360@gmail.com>
…m referencesource. Signed-off-by: Connor McAdams <conmanx360@gmail.com>
…lement. This replaces the SaveContext.HasValue method now that Unmerge works properly. Signed-off-by: Connor McAdams <conmanx360@gmail.com>
…anged locally. Signed-off-by: Connor McAdams <conmanx360@gmail.com>
…lue to a SettingValueElement. This avoids reuse of an existing XmlNode that is supposed to hold a previous setting value. Signed-off-by: Connor McAdams <conmanx360@gmail.com>
madewokherd
pushed a commit
to madewokherd/wine-mono
that referenced
this pull request
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the final patches necessary to fix the
configuration-with-defaultstest.With these patches, the follow tests are fixed as well: