-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port epochX CODEGEN from 270gpu to the 311lovec branch (and pick up the new features there!) #360
Comments
In doing this upgrade, I should try to stick closer to the original code - adressing issues such as #341 reported by Olivier |
As discusset today with Olivier, note that the 311_lo_vec branch includes multichannel outputs. IIUC there is one more python function with one more argument, which creates the C++ with the additional argument needed for multichannel. Note also Olivier's suggestion to try out this process to check all looks good
(The "vector_size" may be renamed to something else, this is the number of events in one "iteration" of our standalone app). |
Hi @oliviermattelaer I have started to work on this in PR #391. I changed the upstream MG5AMC that I am using with my plugins, from 2.7.0_gpu to 3.1.1_lo_vectorization. Surprisingly (or maybe not?), I see no changes at all in source code except for comments. Maybe I should actually change the templates I am using to realign them to those from the new branch?... |
I am splitting this into two separate parts
The resaons is that I want to have a single environment variable MG5AMC_HOME pointing to a single (311) installation, while doing other work |
One of the new features in v311 (not the only one) is helicity recycling. THis is the third time I repeat this comment: Within PR #401, note that I had to introduce this fix while moving to v311 In practice
|
Reminder for myself:
|
I am closing this. The "picking up new features from the 311 branch" is mainly the multichannel stuff. This is discussed in #342. I have just renamed that to mention the 311 branch:
|
Hi @oliviermattelaer I assign this on myself - then we need to discuss when I should start.
All of my epochX CODEGEN is now based on the branch 270gpu of launchpad and specifically on revision 370
madgraph4gpu/epochX/cudacpp/CODEGEN/MG5aMC_patches/2.7.0_gpu/revision.BZR
Line 1 in aa65924
This is this revision
https://bazaar.launchpad.net/~maddevelopers/mg5amcnlo/2.7.0_gpu/revision/370
I understand I should be moving instead to this other branch
https://code.launchpad.net/~maddevelopers/mg5amcnlo/3.1.1_lo_vectorization
For instance this includes the patch for issue #343 about nprocesses:
https://bazaar.launchpad.net/~maddevelopers/mg5amcnlo/3.1.1_lo_vectorization/revision/990
(En passant this is also eventually needed as a prerequisite for helicity recycling I guess, #279).
Details to be discussed, thanks Andrea
The text was updated successfully, but these errors were encountered: