Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit make targets for cuda, cppnone, cppsse4 etc (avoid building CUDA code 5 times for each C++ AVX mode) #680

Closed
valassi opened this issue Jun 4, 2023 · 3 comments · Fixed by #798
Closed

Explicit make targets for cuda, cppnone, cppsse4 etc (avoid building CUDA code 5 times for each C++ AVX mode) #680

valassi opened this issue Jun 4, 2023 · 3 comments · Fixed by #798

Comments

@valassi
Copy link
Member

valassi commented Jun 4, 2023

Part of the cleanup of builds. Avoid building CUDA code 5 times for each C++ AVX mode. This is a bit the mirror of #679: CUDA builds should not depend on C++ builds and viceversa
This was referenced Jun 4, 2023
Open
Closed
@valassi valassi mentioned this issue Jul 18, 2023
Closed
@valassi
Copy link
Member Author

valassi commented Jul 19, 2023

Note: in MR #723 fixing #725, I improved the separation of cpu and gpu namespaces (so now it is a bit sfare to mix the two codes... though it is maybe a better idea not to do that anyway). Maybe eventually we need separate namespaces for all SIMD modes (if we go to fat binaries...).

@valassi valassi changed the title Avoid building CUDA code 5 times for each C++ AVX mode Explicit make targets for cuda, cppnone, cppsse4 etc (avoid building CUDA code 5 times for each C++ AVX mode) Aug 17, 2023
@valassi
Copy link
Member Author

valassi commented Aug 17, 2023

I have added a long todo list in #602. When that task is done, it will also solve this #680.

@valassi
Copy link
Member Author

valassi commented Mar 26, 2024

Like #602, this will be fixed by PR #798.

@valassi valassi linked a pull request Mar 26, 2024 that will close this issue
Jorgen's makefiles with separate builds for CUDA, HIP and C++ #798
Merged
@valassi valassi mentioned this issue Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jorgen's makefiles with separate builds for CUDA, HIP and C++ valassi/madgraph4gpu
1 participant
@valassi