selected color comparison fails for HIP on LUMI

[valassi]

New issue, the selected color comparison fails for HIP on LUMI. This succeeds for CUDA instead.

[valassia@nid007961 bash] ~/GPU2024/madgraph4gpu/epochX/cudacpp/gg_tt.mad/SubProcesses/P1_gg_ttx > ./build.hip_d_inl0_hrd0/runTest_hip.exe 
INFO: The following Floating Point Exceptions will cause SIGFPE program aborts: FE_DIVBYZERO, FE_INVALID, FE_OVERFLOW
[==========] Running 4 tests from 4 test suites.
[----------] Global test environment set-up.
[----------] 1 test from SIGMA_SM_GG_TTX_GPU_XXX
[ RUN      ] SIGMA_SM_GG_TTX_GPU_XXX.testxxx
[       OK ] SIGMA_SM_GG_TTX_GPU_XXX.testxxx (0 ms)
[----------] 1 test from SIGMA_SM_GG_TTX_GPU_XXX (0 ms total)

[----------] 1 test from SIGMA_SM_GG_TTX_GPU_MISC
[ RUN      ] SIGMA_SM_GG_TTX_GPU_MISC.testmisc
[       OK ] SIGMA_SM_GG_TTX_GPU_MISC.testmisc (12 ms)
[----------] 1 test from SIGMA_SM_GG_TTX_GPU_MISC (12 ms total)

[----------] 1 test from SIGMA_SM_GG_TTX_GPU_NOMULTICHANNEL
[ RUN      ] SIGMA_SM_GG_TTX_GPU_NOMULTICHANNEL.compareMomAndME
INFO: Opening reference file ../../test/ref/dump_CPUTest.Sigma_sm_gg_ttx.txt
./MadgraphTest.h:328: Failure
Expected equality of these values:
  testDriver->getSelectedColor( ievt )
    Which is: -1094795586
  referenceData[iiter].SelCols[ievt]
    Which is: 0
Google Test trace:
./MadgraphTest.h:296: In comparing event 0 from iteration 0
   0  7.500000000000000e+02  0.000000000000000e+00  0.000000000000000e+00  7.500000000000000e+02
ref0  7.500000000000000e+02  0.000000000000000e+00  0.000000000000000e+00  7.500000000000000e+02

   1  7.500000000000000e+02  0.000000000000000e+00  0.000000000000000e+00 -7.500000000000000e+02
ref1  7.500000000000000e+02  0.000000000000000e+00  0.000000000000000e+00 -7.500000000000000e+02

   2  7.499999999999994e+02  5.849331413473446e+02 -3.138365726669762e+02 -3.490842674916364e+02
ref2  7.500000000000001e+02  5.849331413473452e+02 -3.138365726669762e+02 -3.490842674916370e+02

   3  7.499999999999998e+02 -5.849331413473448e+02  3.138365726669760e+02  3.490842674916368e+02
ref3  7.499999999999999e+02 -5.849331413473452e+02  3.138365726669762e+02  3.490842674916369e+02

  ME  6.797636301916550e-01
r.ME  6.797636301916554e-01
  ChanId1
r.ChanId1
  SelHel1
r.SelHel1
  SelCol-1094795586
r.SelCol0

[  FAILED  ] SIGMA_SM_GG_TTX_GPU_NOMULTICHANNEL.compareMomAndME (18 ms)
[----------] 1 test from SIGMA_SM_GG_TTX_GPU_NOMULTICHANNEL (18 ms total)

[----------] 1 test from SIGMA_SM_GG_TTX_GPU_MULTICHANNEL
[ RUN      ] SIGMA_SM_GG_TTX_GPU_MULTICHANNEL.compareMomAndME
INFO: Opening reference file ../../test/ref/dump_CPUTest.Sigma_sm_gg_ttx.txt2
./MadgraphTest.h:328: Failure
Expected equality of these values:
  testDriver->getSelectedColor( ievt )
    Which is: 1
  referenceData[iiter].SelCols[ievt]
    Which is: 2
Google Test trace:
./MadgraphTest.h:296: In comparing event 64 from iteration 0
   0  7.500000000000000e+02  0.000000000000000e+00  0.000000000000000e+00  7.500000000000000e+02
ref0  7.500000000000000e+02  0.000000000000000e+00  0.000000000000000e+00  7.500000000000000e+02

   1  7.500000000000000e+02  0.000000000000000e+00  0.000000000000000e+00 -7.500000000000000e+02
ref1  7.500000000000000e+02  0.000000000000000e+00  0.000000000000000e+00 -7.500000000000000e+02

   2  7.499999999999999e+02  3.967977363399760e+02  1.264105709968620e+02 -6.237563017523095e+02
ref2  7.499999999999998e+02  3.967977363399760e+02  1.264105709968621e+02 -6.237563017523095e+02

   3  7.500000000000000e+02 -3.967977363399760e+02 -1.264105709968621e+02  6.237563017523095e+02
ref3  7.499999999999999e+02 -3.967977363399760e+02 -1.264105709968621e+02  6.237563017523095e+02

  ME  2.911980883026979e+00
r.ME  2.911980883026980e+00
  ChanId3
r.ChanId3
  SelHel1
r.SelHel1
  SelCol1
r.SelCol2

[  FAILED  ] SIGMA_SM_GG_TTX_GPU_MULTICHANNEL.compareMomAndME (9 ms)
[----------] 1 test from SIGMA_SM_GG_TTX_GPU_MULTICHANNEL (9 ms total)

[----------] Global test environment tear-down
[==========] 4 tests from 4 test suites ran. (40 ms total)
[  PASSED  ] 2 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] SIGMA_SM_GG_TTX_GPU_NOMULTICHANNEL.compareMomAndME
[  FAILED  ] SIGMA_SM_GG_TTX_GPU_MULTICHANNEL.compareMomAndME

 2 FAILED TESTS
INFO: No Floating Point Exceptions have been reported
INFO: No Floating Point Exceptions have been reported

[valassi]

Ok this is fixed. Will also be added to #882

There were three issues, in order in which I saw them

• fixed debug printout r.SelHel1 into r.SelHel 1
• fixed color selection for channelId==0, now SelCol-1094795586 becomes SelCol 0
• main issue: the random numbers for helicity and color selection were not computed, and this was 0 for cuda, a random negative number for HIP

Now regenerating all processes and recomputing all reference logs

In practice, I think that this is because CUDA arrays were initialsed to 0 while HIP arrays were not (I will not touch this, it is actually useful for debugging...)

[valassi]

Mentioned in 882, closing