Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang-format version and eventually upgrade from v15 to v17 #952

Closed
valassi opened this issue Aug 6, 2024 · 0 comments · Fixed by #953
Closed

Fix clang-format version and eventually upgrade from v15 to v17 #952

valassi opened this issue Aug 6, 2024 · 0 comments · Fixed by #953
Assignees

Comments

@valassi
Copy link
Member

valassi commented Aug 6, 2024

I am using two different machines

[avalassi@itgold91 gcc11/usr] ~> clang-format --version
clang-format version 17.0.6 (AlmaLinux OS Foundation 17.0.6-5.el9)
[avalassi@itgold91 gcc11/usr] ~> more /etc/redhat-release 
AlmaLinux release 9.4 (Shamrock Pampas Cat)

[avalassi@itscrd90 bash] ~> clang-format --version
clang-format version 15.0.7 (Red Hat 15.0.7-2.el9)
[avalassi@itscrd90 bash] ~> more /etc/redhat-release 
AlmaLinux release 9.2 (Turquoise Kodkod)

All code so far was formatted with the latter ie clang-format v15.

I noticed some differences between clang-format 15 and 17.
The templates for codegen etc must be ported to v17.

For the moment I will simply fix the version to <=15 using clang-format from cvmfs.

@valassi valassi self-assigned this Aug 6, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this issue Aug 6, 2024
…-format v15 from cvmfs if a more recent version is installed madgraph5#952
@valassi valassi linked a pull request Aug 7, 2024 that will close this issue
valassi added a commit to valassi/madgraph4gpu that referenced this issue Aug 7, 2024
…-format v15 from cvmfs if a more recent version is installed madgraph5#952
valassi added a commit to valassi/madgraph4gpu that referenced this issue Aug 7, 2024
…-format v15 from cvmfs if a more recent version is installed madgraph5#952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant