Regenerate code (and susyggt1t1 reference logs) with couplings fix from PR 918 #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dX.sh -susyggt1t1 -makeclean) - yes indeed will revert
Revert "[susy2] check that issue madgraph5#826 is still pending (./tmad/teeMadX.sh -susyggt1t1 -makeclean) - yes indeed will revert" This reverts commit 8d0ee2c.
This was referenced Jul 22, 2024
Merged
…e variables in main sequence and inside functions
…but after fixing PASSED in tput scripts - all ok ./tput/teeThroughputX.sh -mix -hrd -makej -susyggt1t1 -makeclean
….sh -susyggt1t1 -makeclean) Will regenerate all processes, launch the CI and later launch manual tests
madgraph5#918 - confirms that only susy_gg_t1t1 code has been affected
…fixing the order of couplings CUDACPP_RUNTEST_DUMPEVENTS=1 ./build.cuda_d_inl0_hrd0/runTest_cuda.exe \cp ../../test/ref/dump* ../../../CODEGEN/PLUGIN/CUDACPP_SA_OUTPUT/test/ref/ \cp ../../test/ref/dump* ../../../susy_gg_t1t1.sa/test/ref/
…d recreating reference logs, all ok ./tput/teeThroughputX.sh -mix -hrd -makej -susyggt1t1 -makeclean
…ll ok, confirming madgraph5#826 is fixed ./tmad/teeMadX.sh -susyggt1t1 -mix +10x
valassi
changed the title
|
Hi @oliviermattelaer this is ready for review for me can you have a look after your holidays please? In addition to the fix in #918, this includes
I suggest approving this, then mering 918, then merging this one. |
oliviermattelaer
approved these changes
Jul 29, 2024
epochX/cudacpp/CODEGEN/PLUGIN/CUDACPP_SA_OUTPUT/model_handling.py
Outdated
Show resolved
Hide resolved
epochX/cudacpp/CODEGEN/PLUGIN/CUDACPP_SA_OUTPUT/model_handling.py
Outdated
Show resolved
Hide resolved
Olivier's suggestion for better pep08 formatting in python Co-authored-by: oliviermattelaer <33414646+oliviermattelaer@users.noreply.github.com>
Olivier's suggestion for better pep08 formatting in python Co-authored-by: oliviermattelaer <33414646+oliviermattelaer@users.noreply.github.com>
Thanks I committed your suggestions (can you tell me how you check pep08 please? coul dbe useful for me too)
Thanks :-) I will resolve conflicts (I have just merged #849 and #939) an dthen merge |
…er merging git checkout upstream/master $(git ls-tree --name-only HEAD */CODEGEN*txt)
…ch PRs madgraph5#849 and madgraph5#939) into susy2
…erging madgraph5#849 and madgraph5#939 - no change in code, only in codegen logs
|
Ok the CI has 3 failing checks. I will merge 918 an dthen merge this one. |
…rder madgraph5#918, and smaller patch madgraph5#939 and madgraph5#849) into susy2 Note: there is no change with respect to the previous origin/susy2 after this merge (no need to rerun the CI)
|
I had to merge upstream/master with 918 into this one. But there is no change anywhere, no need to rerun teh CI. I wil ljust merge. |
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Jul 29, 2024
…rder madgraph5#918 and madgraph5#934, and smaller patch madgraph5#939 and madgraph5#849) into pptt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerate code with couplings fix from PR 918
This is simply an extension of PR #918 adding code regeneration - and I will add a few more manual tests probably