Reorganized/cleaned goodvoxels resampling.py #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
GregConan
commented
Dec 5, 2022
GregConan
commented
- Removed duplicate code in resampling.py by abstracting it into functions, clarifying the goodvoxels logic
- Implemented these formatting suggestions by Mathias:
- ENH: Add option to exclude projecting high variance voxels to surface nipreps/nibabies#235
- ENH: Add option to exclude projecting high variance voxels to surface nipreps/fmriprep#2855
- Split the 3 workflow-connect blocks in the project-goodvoxels section of resampling.py into 3 different functions: ribbon, outliers, and vol-to-surf
- Incomplete comments in resampling.py
- Still need to integrate interfaces/metric.py into workflows/bold/resampling.py
Removed duplicate code by abstracting it into functions, clarifying the goodvoxels logic
- Implemented the formatting suggestions by Mathias at the URLs below:
- nipreps#235
- nipreps/fmriprep#2855
- Split the 3 workflow-connect blocks in the project-goodvoxels section of resampling.py into 3 different functions: ribbon, outliers, and vol-to-surf
- Incomplete comments in resampling.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.