Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test suite #192

Closed
arekm opened this issue Jan 3, 2017 · 2 comments
Closed

test suite #192

arekm opened this issue Jan 3, 2017 · 2 comments

Comments

@arekm
Copy link

arekm commented Jan 3, 2017

Not sure which build method (cmake or old ./configure && make) is the official way now but seems that each of these method runs different test suite at "make test".

That's the first problem.

Second problem is that running old way - "./configure; make; make test" doesn't exit with non-zero status if any test fails. exit status is always 0 regardless of actual test result.

Fedora, PLD and possibly other distros use 'make test' to run test suite. With exit status being always 0 that test is useless.
@madler
Copy link
Owner

madler commented Jan 3, 2017 •
edited
Loading

I maintain configure and make, so that is the official way. I test with configure and make, and don't use cmake. The cmake configurations are provided by others, so those are not as consistent.

I will look at fixing the exit status problem.

@tbeu tbeu mentioned this issue Feb 12, 2017
Closed
@madler
Copy link
Owner

madler commented Oct 13, 2017

I am finding that make test returns a non-zero error code if there is an error.

@madler madler closed this as completed Oct 13, 2017
hzhuang1 pushed a commit to Linaro/warpdrive-zlib that referenced this issue Jul 31, 2019
@Dead2
fix bug madler#192, oss-fuzz/9827 : MemorySanitizer:DEADLYSIGNAL
29b6ab4 
==4908==ERROR: MemorySanitizer: SEGV on unknown address 0x730fffffffff (pc 0x0000004b1b97 bp 0x7ffd4bf59a00 sp 0x7ffd4bf598a0 T4908)
==4908==The signal is caused by a READ memory access.
  #0 0x5a0599 in fizzle_matches zlib-ng/deflate_medium.c:168:12
  madler#1 0x59ea27 in deflate_medium zlib-ng/deflate_medium.c:296:21
  madler#2 0x5901c5 in zng_deflate zlib-ng/deflate.c:951:18
  madler#3 0x586955 in zng_compress2 zlib-ng/compress.c:59:15
  madler#4 0x5861eb in LLVMFuzzerTestOneInput zlib-ng/test/fuzz/compress_fuzzer.c:18:3
  madler#5 0x4e9b48 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/libfuzzer/FuzzerLoop.cpp:575:15
  madler#6 0x4a2f66 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) /src/libfuzzer/FuzzerDriver.cpp:280:6
  madler#7 0x4b3adb in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/libfuzzer/FuzzerDriver.cpp:715:9
  madler#8 0x4a2091 in main /src/libfuzzer/FuzzerMain.cpp:20:10
  madler#9 0x7fa3d7ff582f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/libc-start.c:291
  madler#10 0x41ec68 in _start
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arekm @madler