Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Update #337

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

CMake Update #337

wants to merge 8 commits into from

Conversation

Mizux
Copy link

@Mizux Mizux commented Jan 29, 2018

  • Update project() to use VERSION (need CMake >= 3.0)
  • Explicit default option for assembly (removed in v1.2.13)
  • Use of target_include_directories() instead of include_directories()
  • Add ZLIB::ZLIB target alias (to follow FindZLIB.cmake convention)
  • Use GNUInstallDirs Module
  • Add Export Targets, Config and ConfigVersion cmake file
  • Use CTest Module for enable/disable test using BUILD_TESTING
    (note: include(CTest) call enable_testing())

@johnb003
Copy link

I'd really like a lot of these changes, is there any problem with these? Perhaps if they were broken into separate pull requests it would be easier to swallow?

@Mizux
Copy link
Author

Mizux commented Jun 20, 2018

As far as I know, I would say @madler doesn't work (i.e. maintain) anymore this repo so it will be never merge.

  1. When you lose interest in a program, your last duty to it is to hand it off to a competent successor.
    The Cathedral and the Bazaar

ps: https://github.com/madler/zlib/pulls?page=1&q=is%3Apr+is%3Aopen+cmake&utf8=%E2%9C%93
29 Open...

niparx pushed a commit to FATMAP/zlib that referenced this pull request Jul 10, 2019
madler#337

Looks like original repo is not maintainable at this moment. There are many good PRs there, but, still, they are not merged or even discussed with ZLib maintainer.
So, we just grab this PR, where are many CMake improvements
@madler madler changed the base branch from master to develop October 12, 2022 01:33
@Neustradamus
Copy link

@Mizux: Can you rebase your PR?

@Neustradamus
Copy link

@madler: I think it is time to look about this?

@Mizux
Copy link
Author

Mizux commented Oct 26, 2022

@Neustradamus on my way to rebase it... (will also fix ortools patch ^v^ )

@Mizux
Copy link
Author

Mizux commented Oct 26, 2022

@Neustradamus just rebased to master any feedback welcome...

FYI: upstream macos job are broken
see: 19d7d6b

@Neustradamus
Copy link

@Mizux: Thanks for your quick rebase... :)

Have you seen this PR for example?

There are a lot of:

CMake PRs:

CMake Issues:

cc: @puneetmatharu.

@Mizux
Copy link
Author

Mizux commented Oct 26, 2022

yes too much, no [cmake] label to flag them.

Will be better to have a cmake zlib committee, try to submit all PR which already have consensus among cmake users, close duplicates then focus on remaining one to have everything merged or rejected...

@Neustradamus
Copy link

@Mizux: Can you rebase your PR?

@Neustradamus Neustradamus mentioned this pull request Jul 30, 2023
@madler
Copy link
Owner

madler commented Aug 18, 2023

There are too many cmake issues and pull requests for me to go through and disposition them, and I wouldn't know what's good or bad anyway. I very much like @Mizux 's suggestion to have a group render on, coordinate, and most importantly verify proposed cmake changes. My main concern are proposed changes that work in one case, but messes up a bunch of others. Ideally this group would be able to cover a good set of platforms.

@Vollstrecker Vollstrecker mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants