-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake Update #337
base: develop
Are you sure you want to change the base?
CMake Update #337
Conversation
I'd really like a lot of these changes, is there any problem with these? Perhaps if they were broken into separate pull requests it would be easier to swallow? |
As far as I know, I would say @madler doesn't work (i.e. maintain) anymore this repo so it will be never merge.
ps: https://github.com/madler/zlib/pulls?page=1&q=is%3Apr+is%3Aopen+cmake&utf8=%E2%9C%93 |
madler#337 Looks like original repo is not maintainable at this moment. There are many good PRs there, but, still, they are not merged or even discussed with ZLib maintainer. So, we just grab this PR, where are many CMake improvements
@Mizux: Can you rebase your PR? |
@madler: I think it is time to look about this? |
@Neustradamus on my way to rebase it... (will also fix ortools patch |
use gvim auto indent with: - expandtab tw=4 sw=4
Be able to use zlib as subproject or via find_package() the same way.
Use GNUInstallDirs cmake module
@Neustradamus just rebased to master any feedback welcome... FYI: upstream macos job are broken |
latest macos runner image now provide gcc-11 ref: https://github.com/actions/runner-images/blob/macOS-12/20221018.2/images/macos/macos-12-Readme.md
@Mizux: Thanks for your quick rebase... :) Have you seen this PR for example? There are a lot of: CMake PRs: CMake Issues: cc: @puneetmatharu. |
yes too much, no [cmake] label to flag them.
Will be better to have a cmake zlib committee, try to submit all PR which already have consensus among cmake users, close duplicates then focus on remaining one to have everything merged or rejected... |
@Mizux: Can you rebase your PR? |
There are too many cmake issues and pull requests for me to go through and disposition them, and I wouldn't know what's good or bad anyway. I very much like @Mizux 's suggestion to have a group render on, coordinate, and most importantly verify proposed cmake changes. My main concern are proposed changes that work in one case, but messes up a bunch of others. Ideally this group would be able to cover a good set of platforms. |
project()
to useVERSION
(need CMake >= 3.0)Explicit default option for assembly(removed in v1.2.13)target_include_directories()
instead ofinclude_directories()
ZLIB::ZLIB
target alias (to followFindZLIB.cmake
convention)GNUInstallDirs
ModuleCTest
Module for enable/disable test usingBUILD_TESTING
(note:
include(CTest)
callenable_testing()
)