Fix configure buglet; verify bit-for-bit identical installs; enhance junit output; add Linux/bsd/mac builders #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it easier to accept contributions to zlib we should establish automated testing. This commit uses the existing test/example.c testing. It connects those tests to AppVeyor, allowing AppVeyor to mark commits as passing or failing the tests. It also automatically runs tests when a pull request is submitted or updated. There is some room for future expansion enabled, such as tracking the file and line of a failing test. This is thanks to @dankegel, who also got this working on CI providers other than AppVeyor.
…#497 - default build type to Release - set -DHIDDEN properly - pass .c files to compiler in same order - on linux/bsd, link libz.so with -lc explicitly (as Makefile.in does, but why?) - output same libz.pc and zconf.h as Make
ci/pkgcheck.sh: verify make and cmake install same bits, and that running configure/make doesn't try to reference wrong zconf.h.
Also don't assume there will only be one option.
This lets the Linux build upload results for both tests (example and example64).
The choice of output formats used to be intertwined with whether to terminate on first failure. New default is to not terminate on first failure, regardless of output formats; use --fail_fast if you want to stop the test on the first failure.
dankegel
changed the title
|
You can see the builders in action at dankegel#7 (same branch, just in a repo where both appveyor and cirrus-ci are enabled). |
This was referenced May 26, 2020
|
https://cirrus-ci.org/guide/quick-start/ explains how to configure your repo to obey the .cirrus.yml in this commit to carry out automated builds. It's pretty easy. |
|
Bouncing to see if CI is enabled yet. |
Open
|
@madler: What do you think? |
|
Applied one fix in 9404df5 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followon to Chris's changes, #492
Fixes #497 and #499