Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Werror/Wall/Wextra #933

Closed
wants to merge 1 commit into from
Closed

add Werror/Wall/Wextra #933

wants to merge 1 commit into from

Conversation

pmqs
Copy link
Contributor

@pmqs pmqs commented Feb 10, 2024

This change makes the existing cmake & configure workflows match the Werror setting used in the c_std workflow

@madler
Copy link
Owner

madler commented Feb 10, 2024

Applied. I thought for sure that everything was going to go to hell, but I got two green check marks!

@madler madler closed this Feb 10, 2024
@pmqs
Copy link
Contributor Author

pmqs commented Feb 10, 2024

Applied. I thought for sure that everything was going to go to hell, but I got two green check marks!

I built it in a fork before pushing here.

@madler
Copy link
Owner

madler commented Feb 10, 2024

Thank you! (Actually, I made it more perilous than what you tested by adding a /W3 to the MSVC builds.)

@pmqs
Copy link
Contributor Author

pmqs commented Feb 10, 2024

Thank you! (Actually, I made it more perilous than what you tested by adding a /W3 to the MSVC builds.)

I tried -Wall -Wextra with MSVC, but it outputted as sorts of crazy stuff. Thought prudent to leave well alone.

@pmqs
Copy link
Contributor Author

pmqs commented Feb 10, 2024

@madler Just looking at the CLAGS line committed to develop in configure.yml

        CFLAGS: ${{ matrix.cflags }} -Werror

The one I posted had this, to make cmake.yml, std-c.yml & configure.yml all use the same warnings settings.

        CFLAGS: ${{ matrix.cflags }} -Werror -Wall -Wextra

@madler
Copy link
Owner

madler commented Feb 10, 2024

-Wall -Wextra are already there from the --warn option to configure.

@Neustradamus Neustradamus mentioned this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants