-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expected semicolon or closing curly-brace, found '-' #306
Comments
Any reason this issue was closed? I'm getting the same problem building Bootstrap 4 beta 2 and downgrading to 2.5.357 didn't work. |
aww I got everything working together - BuildBundlerMinifier (2.6.362) and BuildWebCompiler (1.11.375) with the latest Visual Studio Community 15.5.2 but I was so busy that I forgot what steps I took to get it working. Maybe the VS updates fixed it? Have you tried to update to the latest? |
@ChrisASearles I have the same setup as you. Removing the top root and -- color vars allowed the minifier to complete. There's another issue open to fix this: #218 |
@davidliang2008 can you re-open this? It's obviously not fixed... anything we can do to help? |
OK, I'll likely take care of NUglify error: trullock/NUglify#17 (comment) Once that's done can we then update this Minifier with new version @davidliang2008? Because it's likely lots of people will run into this problem now that Bootstrap4 uses CSS variables ( |
Pull request submitted to NUglify: trullock/NUglify#46 Once they merge can we update dependency and publish new version @madskristensen ? |
This just got merged! |
... and nuget pushed :) |
@NicolasDorier french connection with @xoofx it seems ;) @madskristensen can we now get new version of BundlerMinifier? So that everyone can use Bootstrap4? |
not even. Now just hoping @madskristensen still use github! Long time since the last activity in this repo. :( |
@NicolasDorier well he seems to be commiting last few days in other repos. If this issue talk doesn't get his attention I guess we can make use of your Twitter firepower. |
Resolves CSS Variables bug related to Bootstrap 4: madskristensen#306
Resolves CSS Variables bug related to Bootstrap 4: #306
2.6.375 out, fixes this problem: https://www.nuget.org/packages/BuildBundlerMinifier/ |
2.8.xxx version fixed it for me |
This may be separate, but this felt like a good place to do put this. If you run into a similar error, for example mine was "Expected semicolon or closing curly-brace, found '@state-text-danger'". Simply remove the @ and wrap the left over in var(--state-text-danger). This allowed me to minify and bundle with no issue. |
Installed product versions
Description
I've been using web compiler to transform .scss files into css files, and the bundler to move and bundle css files into wwwroot directory.
Issue 1:
I noticed this version of the bundler won't minify the files automatically, like what the previous version 2.5.357 would do, but I think I can do that via settings so I didn't bother to look into this any deeper.
Issue 2:
Everything worked fine until I enable bundle on build, which downloaded 2 NuGet packages: BuildBundlerMinifier (2.6.362) and BuildWebCompiler (1.11.375).
I got 28 errors. All said
Expected semicolon or closing curly-brace, found '-'
(this might be related to #295). And there is a yellow warning sign on BuildBundlerMinifier (as well as BuildWebCompiler) if you pop open Dependencies -> NuGet under the web project.Notes:
I downgraded the BuildBundlerMinifier to 2.5.357 and everything worked perfectly - it generates a minified version of the bundle files, as well as generates bundles on build.
Steps to recreate
npm install bootstrap@4.0.0-beta.2
@import "../../node_modules/bootstrap/scss/bootstrap";
compilerconfig.json
filebundleconfig.json
and output the dark.css file to wwwroot[ { "outputFileName": "wwwroot/css/global.css", "inputFiles": [ "assets/styles/dark.css" ] } ]
The text was updated successfully, but these errors were encountered: