Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace VsctGenerator with a Roslyn source generator #10

Closed
wants to merge 3 commits into from

Conversation

sharwell
Copy link
Collaborator

@sharwell sharwell commented Jan 8, 2022

No description provided.

@sharwell sharwell mentioned this pull request Jan 8, 2022
@madskristensen
Copy link
Owner

Thank you, Sam!!! I would love to put this in a NuGet package on the VsixCommunity org alongside a generator for .vsixmanifest files to replace the VSIX Synchronizer extension.

/cc @reduckted since I believe you've expressed interest in source generators in the past

@reduckted
Copy link

What a coincidence! Just the other week I tried writing a source generator as a replacement for VSIX Synchronizer (for both .vsct and .vsixmanifest files). It worked great, except when using it in projects that need to compile WPF classes.

I ran into this bug: dotnet/wpf#3404

I tried the suggested workaround of adding <IncludePackageReferencesDuringMarkupCompilation>true</IncludePackageReferencesDuringMarkupCompilation> to the extension's project file, but that didn't seem to make any difference. Perhaps because it's not using the .NET SDK to compile it? I never did get time to come back and debug it further. 😞

In any case, my intention was for it to end up as part of the VsixCommunity. The source generator I wrote wasn't incremental, but it might be a good starting point. If you'd like, I can add it to a new repository in the VsixCommunity and we can try to improve it?

@reduckted
Copy link

@madskristensen @sharwell
I've just created Community.VisualStudio.SourceGenerators in the VsixCommunity org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants