Disposing document when file closes

[release]
madskristensen · Dec 22, 2021 · 247241b · 247241b
1 parent c49e2d9
commit 247241b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/Language/ErrorListManager.cs b/src/Language/ErrorListManager.cs
@@ -92,6 +92,7 @@ private IEnumerable<ErrorListItem> CreateErrorListItem(ParseItem item)
         protected override void Closed(IWpfTextView textView)
         {
             _document.Parsed -= ParseErrors;
+            _document.Dispose();
             _dataSource.CleanAllErrors();
         }
     }

diff --git a/src/PkgdefDocument.cs b/src/PkgdefDocument.cs
@@ -1,12 +1,14 @@
-using System.Linq;
+using System;
+using System.Linq;
 using Microsoft.VisualStudio.Shell;
 using Microsoft.VisualStudio.Text;
 
 namespace PkgdefLanguage
 {
-    public class PkgdefDocument : Document
+    public class PkgdefDocument : Document, IDisposable
     {
         private readonly ITextBuffer _buffer;
+        private bool _isDisposed;
 
         public PkgdefDocument(ITextBuffer buffer)
             : base(buffer.CurrentSnapshot.Lines.Select(line => line.GetTextIncludingLineBreak()).ToArray())
@@ -25,5 +27,14 @@ public static PkgdefDocument FromTextbuffer(ITextBuffer buffer)
         {
             return buffer.Properties.GetOrCreateSingletonProperty(() => new PkgdefDocument(buffer));
         }
+
+        public void Dispose()
+        {
+            if (!_isDisposed)
+            {
+                _buffer.Changed -= BufferChanged;
+                _isDisposed = true;
+            }
+        }
     }
-}
+}