Improve 'compilation required' check by checking source file dependencies #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krusen
force-pushed
the
compilation-required-fix
branch
from
0bfe7fd to
7aa5068
Compare
Krusen
force-pushed
the
compilation-required-fix
branch
from
7aa5068 to
c965f5c
Compare
|
I've added some unit tests to show that it actually works. |
|
Did you see my comment on the File.Exist check? |
|
No, I don't see any comments at all. |
|
@madskristensen If you will point it out again I'll get it fixed :) |
src/WebCompiler/Config/Config.cs
Outdated
| foreach (var file in dependencies[key].DependentOn.ToArray()) | ||
| { | ||
| var fileInfo = new FileInfo(file); | ||
| if (fileInfo.LastWriteTimeUtc > output.LastWriteTimeUtc) |
There was a problem hiding this comment.
Should there be a check for fileInfo.Exist before calling the LastWriteTimeUtc properties?
There was a problem hiding this comment.
According to the documentation if the file doesn't exist it will return 12:00 midnight, January 1, 1601 A.D. (C.E.) Coordinated Universal Time (UTC), but it would of course be good practice to just check if it exists and make the intention more clear.
I'll add the check.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This recursively check the last write time of all the files for which the input file depends on (e.g.
@importetc.) instead of only the input file.Without this there can be situations where the input files has not been changed but dependent files have been changed outside Visual Studio (e.g. by source control) and would not be recompiled. This can often happen with the "build on compile" feature after switching branches or fetching updates.