Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with .NET CLI version of MsBuild #330

Merged
merged 6 commits into from
Oct 12, 2017
Merged

Compatibility with .NET CLI version of MsBuild #330

merged 6 commits into from
Oct 12, 2017

Conversation

djanosik
Copy link
Contributor

@djanosik djanosik commented Sep 19, 2017

I've made some changes to make WebCompiler task compatible with .NET CLI version of MsBuild:

  • WebCompiler project now targets net46, netstandard2.0 and netcoreapp2.0.
  • The BuildWebCompiler.targets now supports .NET Core MsBuild.
  • I have also removed the BuildDependsOn attribute, because I think it's better to use the BeforeTargets attribute. The WebCompile target will now always run before BundleMinify and BeforeCompile targets. But it will run only once of course.
  • AjaxMin has been replaced with NUglify. It required minimum changes.
  • The BuildWebCompiler.nuspec file has been removed.

It should fix issues #328, #237 and #321.

@djanosik
Copy link
Contributor Author

@madskristensen I am not sure whether I should update the build script. I have no idea how do you handle versioning, etc.

@djanosik
Copy link
Contributor Author

Ok, I think I've managed to fix the build configuration.

@304NotModified
Copy link

@madskristensen can this be merged?

@madskristensen madskristensen merged commit 25bc229 into madskristensen:master Oct 12, 2017
@madskristensen
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants