Sass: Removes post-processing path normalization #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes unused usings. * Eliminates unnecessary branches. * Renames `NodeExecutorBase`'s override methods.
|
@madskristensen, after this, we are set for v2.6 IMHO. |
LibSass does not support relative paths resolution. Nor does ruby-sass (unless we use Compass). At present, WE tries to resolve the URLs in the post-compilation step by using one base path. This misleads in the scenarios where we have nested imports and the meaning of 'relative path' need to be twisted to justify the outcome. :) Less provides this functionality OOTB. We will have to wait for LibSass to provide this functionality; either sass/libsass#674 or sass/libsass#532 gets addressed;
madskristensen
added a commit
that referenced
this pull request
Jun 27, 2015
Sass: Removes post-processing path normalization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1f5c263:
LibSass does not support relative paths resolution. Nor does ruby-sass
(unless we use Compass). At present, WE tries to resolve the URLs in
the post-compilation step by using one base path. This misleads in the
scenarios where we have nested imports and the meaning of
'relative path' need to be twisted to justify the outcome. :)
Less provides this functionality OOTB. We will have to wait for LibSass
to provide this functionality; either sass/libsass#674 or
sass/libsass#532 gets addressed.
7c2583b:
Code: General fixes.
NodeExecutorBase's override methods.