Fix IMP being a valid NULL in class_replaceMethod

madsmtm · Sep 4, 2021 · 109a816 · 109a816
1 parent 9c8738c
commit 109a816
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/objc_sys/src/class.rs b/objc_sys/src/class.rs
@@ -102,7 +102,7 @@ extern "C" {
         name: *const objc_selector,
         imp: IMP,
         types: *const c_char,
-    ) -> IMP;
+    ) -> Option<IMP>;
     pub fn class_replaceProperty(
         cls: *mut objc_class,
         name: *const c_char,

diff --git a/objc_sys/src/various.rs b/objc_sys/src/various.rs
@@ -12,8 +12,7 @@ pub struct objc_ivar {
 
 /// A pointer to the start of a method implementation.
 ///
-/// Remember that this is non-null!
-/// Use `Option<IMP>` where nullability is expected. TODO
+/// This must be non-null. Use `Option<IMP>` when nullability is desired.
 pub type IMP = unsafe extern "C" fn();
 
 /// Not available on macOS x86.