Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support super in msg_send_id! #173

Closed
wants to merge 3 commits into from
Closed

Support super in msg_send_id! #173

wants to merge 3 commits into from

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Jun 15, 2022

Ties in with #282.

The allowed types when using this should be:

msg_send_id![super(obj), new];   // Disallow with a note that you probably want to do stuff in `init` instead?
msg_send_id![super(obj), alloc]; // Disallow for now
msg_send_id![super(obj), init];  // Allocated<T: ClassType> -> Option<Id<T, O>>
msg_send_id![super(obj), copy];  // T: ClassType -> impl MaybeUnwrap<Id<T, O>>
msg_send_id![super(obj), other]; // T: ClassType -> impl MaybeUnwrap<Id<T, O>>

And the retain semantics should just be the same as msg_send_id!.

@madsmtm madsmtm added enhancement New feature or request A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates labels Jun 15, 2022
@madsmtm madsmtm mentioned this pull request Jun 15, 2022
12 tasks
@madsmtm madsmtm added this to the objc2 v0.3 milestone Jan 18, 2023
This was referenced Jan 26, 2023
@madsmtm madsmtm modified the milestones: objc2 v0.4, icrate v0.1.0 Apr 21, 2023
@madsmtm madsmtm mentioned this pull request Oct 3, 2023
5 tasks
@madsmtm madsmtm closed this in #521 Dec 3, 2023
@madsmtm madsmtm deleted the msg-send-id-super branch December 3, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant