Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework verification feature selection #198

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Rework verification feature selection #198

merged 4 commits into from
Nov 15, 2022

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Jul 16, 2022 •
edited
Loading

  • Always only on debug_assertions
  • Most of it is enabled by default
  • The rest can be enabled with the "verify" feature

This will also allow better error messages in the future, ideally the error would state the required change to your Encode/RefEncode implementation.

TODO:

@madsmtm madsmtm added enhancement New feature or request A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates labels Jul 16, 2022
@madsmtm madsmtm mentioned this pull request Jul 19, 2022
Closed
@madsmtm madsmtm added this to the objc2 v0.3 milestone Aug 22, 2022
@madsmtm madsmtm mentioned this pull request Aug 22, 2022
Merged
@madsmtm madsmtm mentioned this pull request Sep 2, 2022
Open
@madsmtm madsmtm mentioned this pull request Sep 21, 2022
Merged
3 tasks
@madsmtm madsmtm mentioned this pull request Nov 11, 2022
Merged
@madsmtm madsmtm force-pushed the verify-under-debug-assertions branch from 931bea7 to 6a810be Compare November 15, 2022 02:53
@madsmtm madsmtm changed the title Verify message sending when debug assertions are enabled Rework verification feature selection Nov 15, 2022
@madsmtm madsmtm marked this pull request as ready for review November 15, 2022 02:58
@madsmtm madsmtm changed the base branch from master to encoding-parse November 15, 2022 02:58
@madsmtm madsmtm force-pushed the verify-under-debug-assertions branch 2 times, most recently from d2a6080 to 4788abd Compare November 15, 2022 03:26
Base automatically changed from encoding-parse to master November 15, 2022 03:27
@madsmtm madsmtm force-pushed the verify-under-debug-assertions branch from 4788abd to 6aa2b8c Compare November 15, 2022 03:27
@madsmtm
Add functionality to iterate over method_getTypeEncoding
2372c9a
@madsmtm
Class::verify_sel no longer needs "malloc" feature
10be165
@madsmtm
Rework verification feature selection
edf5e65 
- Always only on `debug_assertions`
- Most of it is enabled by default
- The rest can be enabled with the `"verify"` feature
@madsmtm
Appease clippy
0e54b46
@madsmtm madsmtm force-pushed the verify-under-debug-assertions branch from 6aa2b8c to 0e54b46 Compare November 15, 2022 03:37
@madsmtm madsmtm merged commit 26a6ded into master Nov 15, 2022
@madsmtm madsmtm deleted the verify-under-debug-assertions branch November 15, 2022 04:39
@madsmtm madsmtm mentioned this pull request Dec 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates enhancement New feature or request
Projects
None yet
Milestone
objc2 v0.3
Development

Successfully merging this pull request may close these issues.
1 participant
@madsmtm