Add HealthKit, MediaPlayer, MetricKit, PhotoKit frameworks #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
requested changes
Feb 22, 2023
There was a problem hiding this comment.
Could I get you to fix the errors that header-translator outputs? (CI should really be able to catch this, but I haven't yet found a good way to go from error! to an ExitCode::FAILURE in main).
Also, a changelog entry would be nice.
madsmtm
added
enhancement
silvanshade
force-pushed
the
more-frameworks
branch
from
60d2047
to
9190f99
Compare
|
Errors should be fixed now and I added a CHANGELOG entry. |
madsmtm
requested changes
Feb 23, 2023
silvanshade
force-pushed
the
more-frameworks
branch
from
9190f99
to
2a296de
Compare
madsmtm
reviewed
Feb 25, 2023
madsmtm
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #404, #406, #407, #405.