Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Class, Object and Protocol to AnyClass, AnyObject and AnyProtocol #463

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Jun 18, 2023

To match Swift's naming, which also matches Rust pretty well in this case; both languages are very strongly typed, so prefixing these type with Any highlights the fact that they're very dynamic.

Other benefits:

  • We'll be able to call the ClassType trait for just Class in the future.
  • Error messages no longer include objc2::runtime::, since the names are unique enough that the compiler doesn't have to.

Part of #284.

@madsmtm madsmtm added enhancement New feature or request A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates labels Jun 18, 2023
@madsmtm madsmtm force-pushed the rename-runtime-types branch 3 times, most recently from 9a633db to d40fef3 Compare June 20, 2023 20:34
@madsmtm madsmtm marked this pull request as ready for review June 20, 2023 21:01
@madsmtm madsmtm force-pushed the rename-runtime-types branch from d40fef3 to 022b12c Compare June 20, 2023 21:01
@madsmtm madsmtm force-pushed the rename-runtime-types branch from 022b12c to ceae1e4 Compare June 22, 2023 09:35
To match Swift's naming, and to be able to call the `ClassType` trait for just `Class` in the future
@madsmtm madsmtm force-pushed the rename-runtime-types branch from ceae1e4 to 679f70f Compare June 22, 2023 09:36
@madsmtm madsmtm merged commit 55703bc into master Jun 22, 2023
@madsmtm madsmtm deleted the rename-runtime-types branch June 22, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant