Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the "usage" example as it's wrong #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

etiago
Copy link

@etiago etiago commented Sep 15, 2017

The usage example has a mistake and makes it so that when people do copy/paste, they end up with a wrong example.

The usage example has a mistake and makes it so that when people do copy/paste, they end up with a wrong example.
@njordhov njordhov mentioned this pull request Sep 22, 2017
@cjohansen
Copy link

You need both namespaces - get-mui-theme resides in cljs-react-material-ui.core

@madvas
Copy link
Owner

madvas commented Sep 23, 2017

This is not really correct. Usage with reagent is lower. To improve readability we can probably rename first "Usage" to "Usage with Om" and make "Using with Reagent" header bigger

@cjohansen
Copy link

Wow, I completely overlooked that as well :( Suggestion: a table of contents on the top, to bring people's attention to the fact that there are multiple guides for setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants