-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We produce warning when packages requires features not enabled #359
Comments
What do |
They both seem to ignore this and not print any sort of warning or whatever. |
nfachan
changed the title
cargo-maelstrom: We produce warning when packages requires features not enabled
We produce warning when packages requires features not enabled
Aug 27, 2024
I want to capture our decision about this before I forget. We decided to just remove the warning, and make some new issue (in some other milestone) about providing better (better than cargo / nextest) insight into test binaries not being built due to the selected features |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now if there is some package that doesn't get built due to it requiring some feature that isn't enabled. We say something like "didn't receive build notification for PackageId { ... }".
On one hand notifying the user that there were package whose tests we didn't run sounds like a good idea, but on the other hand it being a warning is maybe undesirable. Maybe we should just somehow make it part of the summary, or else just kill the warning.
The text was updated successfully, but these errors were encountered: