Fix compilation warnings on Ecto 3.2.0 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ecto 3.2.0 defines two new callbacks for types, they provide default implementations for them if the type uses `use Ecto.Type` instead of `@behaviour Ecto.Type`, but this breaks compatibility with anything less than Ecto 3.2.0, so the default implementations are just hardcoded here.
rinpatch
force-pushed
the
fix/ecto-type-compilation-warnings
branch
from
f6ec680 to
aee4587
Compare
rinpatch
changed the title
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ecto 3.2.0 defines two new callbacks for types, they provide default
implementations for them if the type uses
use Ecto.Typeinstead of@behaviour Ecto.Type, but this breaks compatibility with anything lessthan Ecto 3.2.0, so the default implementations are just hardcoded here.
Closes #62