[MNOE-474] Update review frontend #219
Conversation
| </div> | ||
| <div class="pull-left links"> | ||
| <a ng-show="vm.anyReviews" ng-click="vm.scrollToReviews()" href="">{{vm.reviews.list.length}} {{'mno_enterprise.templates.dashboard.marketplace.show.reviews' | translate}}</a> | ||
| <span ng-if="vm.anyReviews && vm.anyQuestions"> | </span> |
There was a problem hiding this comment.
Use : |
I'm afraid that the code uglifier will remove those spaces after a build.
|
@alexnoox replaced spaces with |
|
@ouranos Please port locales to mno-enterprise and merge |
src/locales/en.locale.json
Outdated
| @@ -519,6 +521,9 @@ | |||
| "mno_enterprise.templates.dashboard.marketplace.show.comment.delete_modal_body": "Do you really want to delete your comment?", | |||
| "mno_enterprise.templates.dashboard.marketplace.show.comment.delete_modal_cancel": "Cancel", | |||
| "mno_enterprise.templates.dashboard.marketplace.show.comment.delete_modal_delete": "Delete", | |||
| "mno_enterprise.templates.dashboard.marketplace.show.comment.hide": "Hide Comments", | |||
| "mno_enterprise.templates.dashboard.marketplace.show.comment": "Comment", | |||
| "mno_enterprise.templates.dashboard.marketplace.show.comments": "Comments", | |||
There was a problem hiding this comment.
You can use pluralisation to manage this (https://angular-translate.github.io/docs/#/guide/14_pluralization)
src/locales/en.locale.json
Outdated
| @@ -519,6 +521,9 @@ | |||
| "mno_enterprise.templates.dashboard.marketplace.show.comment.delete_modal_body": "Do you really want to delete your comment?", | |||
| "mno_enterprise.templates.dashboard.marketplace.show.comment.delete_modal_cancel": "Cancel", | |||
| "mno_enterprise.templates.dashboard.marketplace.show.comment.delete_modal_delete": "Delete", | |||
| "mno_enterprise.templates.dashboard.marketplace.show.comment.hide": "Hide Comments", | |||
There was a problem hiding this comment.
Rename this key to mno_enterprise.templates.dashboard.marketplace.show.hide_comments. If a key is used (ie. mno_enterprise.templates.dashboard.marketplace.show.comment) we cannot reuse it by adding .hide. It has to be translated to YAML and this format do not accept it.
adamaziz15
force-pushed
the
feature/474-refresh-review-frontend
branch
from
be59cab to
ae9c957
Compare
|
@alexnoox updated locales and view to use pluralization |
|
@alexnoox Updated locales and created PR in mnoe. Please review. |
|
@alexnoox locales all good for me. Let's merge in |
|
@ouranos Ok, let's do it |
|
Locales merged in maestrano/mno-enterprise#334 |
@alexnoox