Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNOE-243] Disable I18n by default in generator #154

Merged

Conversation

ouranos
Copy link
Contributor

@ouranos ouranos commented Nov 21, 2016

Disable I18n when generating a new project as it won't be needed for
most projects.
This can still be enabled in the initializer if needed.

Disable I18n when generating a new project as it won't be needed for
most projects.
This can still be enabled in the initializer if needed.
@ouranos
Copy link
Contributor Author

ouranos commented Nov 21, 2016

@adamaziz15 @hedudelgado FYI

@hedudelgado
Copy link
Contributor

👍

Copy link
Contributor

@x4d3 x4d3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a long, and painful review. I approve it. I think it is a good change.
I would like to thank all the team on the hard work and effort that led to this success.

@ouranos ouranos merged commit 769c1ac into maestrano:master Nov 22, 2016
@ouranos ouranos deleted the feature/243-disable-i18n-in-generator branch November 22, 2016 08:23
aluqueGH pushed a commit to aluqueGH/mno-enterprise that referenced this pull request Jul 10, 2018
Fixed a bug hidding filters when no app instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants