Implement comments management in Admin Panel #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedudelgado
force-pushed
the
implement-comments-in-admin-panel
branch
from
4030fb4 to
a22b92c
Compare
alexnoox
suggested changes
Nov 29, 2016
| # Display an error | ||
| $log.error('Error while fetching ratings', error) | ||
| toastr.error('An error occured while fetching the ratings.') | ||
| ) |
There was a problem hiding this comment.
If you want to catch the errors, you can use catch(errorCallback):
# GET List /mnoe/jpi/v1/admin/app_user_ratings
@list = () ->
MnoeAdminApiSvc.all('app_user_ratings').getList().catch(
(error) ->
# Log and display an error
$log.error('Error while fetching ratings', error)
toastr.error('An error occured while fetching the ratings.')
)| # # Display an error | ||
| # $log.error('Error while deleting rating', error) | ||
| # toastr.error('An error occured while deleting the rating.') | ||
| # ) |
There was a problem hiding this comment.
Please remove dead/commented code
| # scope.remove = (rating) -> | ||
| # MnoeRatings.removeRating(rating.id).then( -> | ||
| # toastr.success("The #{rating.user_name}\'s rating has been successfully removed.") | ||
| # ) |
There was a problem hiding this comment.
Please remove dead/commented code
alexnoox
reviewed
Nov 29, 2016
| <div class="row"> | ||
| <div class="col-xs-8 col-lg-offset-1 top-buffer-1"> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
If there is nothing in this row, you can remove it.
|
@alexnoox I am going to merge this in the feature branch, but I will address your comment and correct it in my next commit. |
aluqueGH
pushed a commit
to aluqueGH/mno-enterprise
that referenced
this pull request
Jul 10, 2018
Fix bug on app description displaying HUGE images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexnoox