[MNO-287] Change developer registration event description

[hedudelgado]

@ouranos
I spotted a little bug on the code while testing it. This should fix it.

[ouranos]

Hi @hedudelgado I don't think you need this. Check with @x4d3.
Also could you find a better description for this event. Thanks

[x4d3]

I confirm that the last argument of the function (metadata) is optional. The method will automatically use the to_audit_event of the user class.

[hedudelgado]

@ouranos

[ouranos]

@x4d3 see if the change is needed?
Also for the description, I'd put something like "User registered as developer" or "Developer registration" to keep it consistent with other events?

[x4d3]

I agree it is important to log the fact that a User registered as a developer. And I agree with the description "Developer registration""

[x4d3]

Could you

[hedudelgado]

@ouranos

[ouranos]

Hi @x4d3 and @hedudelgado

As mentioned above, we changed the method signature in master to be

self.info(key, current_user_id, description, object, metadata = {})

So the metadata is optional and object.to_audit_event is called if metadata is not provided.

Please fix this PR to only amend the event description or explain how this is fixing a bug

Thanks

[ouranos]

Hi @x4d3 and @hedudelgado, could you look at the above? Thanks

[hedudelgado]

His @x4d3 and @ouranos , unable to reproduce the bug that I apparently had, I cleaned the commits up and only include the changes on the description.