Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locales generate task copying to wrong location #190

Closed
wants to merge 3 commits into from
Closed

Fix locales generate task copying to wrong location #190

wants to merge 3 commits into from

Conversation

xaun
Copy link
Contributor

@xaun xaun commented Jan 13, 2017

Hey @ouranos @clemthenem the changes introduced in #187 caused the locales to be incorrectly copied from tmp/ to public/dashboard/locales/locales.

Please review, 🍻

@ouranos ouranos mentioned this pull request Jan 15, 2017
@ouranos
Copy link
Contributor

ouranos commented Jan 15, 2017

Thanks for picking this up.
I've merged you 2 PR in one in #192

By the way, don't remove "unused" spec files, that's something to be done, but haven't got around to do it yet ;)

@ouranos ouranos closed this Jan 15, 2017
@xaun
Copy link
Contributor Author

xaun commented Jan 15, 2017

@ouranos isn't the spec I removed (frontend/spec/lib/mno_enterprise/locales_generator_spec.rb) duplicated by frontend/spec/lib/tasks/mnoe_locales_rake_spec.rb??

@xaun xaun deleted the fix-locales-generate branch January 15, 2017 10:00
aluqueGH pushed a commit to aluqueGH/mno-enterprise that referenced this pull request Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants