Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNOE-282] App comparison config #199

Merged
merged 1 commit into from
Jan 25, 2017
Merged

[MNOE-282] App comparison config #199

merged 1 commit into from
Jan 25, 2017

Conversation

c3gdlk
Copy link
Contributor

@c3gdlk c3gdlk commented Jan 24, 2017

…unning_instances_count into the API response

[MNOE-282] Add MARKETPLACE_CONFIG to Angular default config and App#r…
4cadb48 
…unning_instances_count into the API response
x4d3
x4d3 approved these changes Jan 24, 2017
View reviewed changes
Copy link
Contributor

@x4d3 x4d3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM !

core/lib/generators/mno_enterprise/install/templates/config/settings.yml
@@ -24,3 +24,7 @@ developer:
# Enable Reviews in the marketplace
reviews:
enabled: false

marketplace:
comparison:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer apps_comparison

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@x4d3 this name came from the issue description. Please confirm that I need to use the apps_comparison, it's 5 min to change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I did not see it. Ignore my remark then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. I'll default it to false though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #201

@ouranos ouranos changed the title [MNOE-282] Add MARKETPLACE_CONFIG to Angular default config and App#r… [MNOE-282] App comparison config Jan 25, 2017
@ouranos ouranos merged commit bead819 into maestrano:3.2 Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x4d3 x4d3 x4d3 approved these changes

@ouranos ouranos ouranos approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c3gdlk @ouranos @x4d3