[MNOE-360] - add flag for impersonating #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouranos
requested changes
Mar 2, 2017
| @@ -10,7 +10,7 @@ class ImpersonateController < ApplicationController | |||
| def create | |||
| session[:impersonator_redirect_path] = params[:redirect_path].presence | |||
| @user = MnoEnterprise::User.find(params[:user_id]) | |||
| if @user.present? | |||
| if @user.present? && (!Settings.admin_panel || !Settings.admin_panel.impersonation.disabled) | |||
There was a problem hiding this comment.
Instead of disabling it in the controller, you can disable it at the route level:
unless Settings.try(:admin_panel).try(:impersonation).try(:disabled)
get "/impersonate/user/:user_id", to: "impersonate#create", as: :impersonate_user
get "/impersonate/revert", to: "impersonate#destroy", as: :revert_impersonate_user
end| @@ -15,6 +15,7 @@ | |||
| displayList: [] | |||
| widgetTitle: 'Loading users...' | |||
| search: '' | |||
| scope.disable_impersonation = ADMIN_PANEL_CONFIG.impersonation.disabled if ADMIN_PANEL_CONFIG.impersonation | |||
There was a problem hiding this comment.
scope.impersonation_enabled
| 'ngInject' | ||
| vm = this | ||
|
|
||
| vm.disable_impersonation = ADMIN_PANEL_CONFIG.impersonation.disabled if ADMIN_PANEL_CONFIG.impersonation |
There was a problem hiding this comment.
scope.impersonation_enabled
|
Also add the default to the generator template: |
clemoberti
force-pushed
the
360_add_flag_for_impersonating
branch
2 times, most recently
from
117b170 to
6c79290
Compare
ouranos
reviewed
Mar 2, 2017
| Rails.application.reload_routes! | ||
| end | ||
|
|
||
|
|
clemoberti
force-pushed
the
360_add_flag_for_impersonating
branch
from
6c79290 to
2e2de1a
Compare
ouranos
approved these changes
Mar 2, 2017
aluqueGH
pushed a commit
to aluqueGH/mno-enterprise
that referenced
this pull request
Jul 10, 2018
…-config [MNOE-448][MNOE-449] Theme previewer dynamic config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ouranos I am missing the spec for this. Cant find how to set a flag...