[IMPAC-578] Create Widget KPIs #306
Conversation
There was a problem hiding this comment.
LGTM
@xaun Is it backward compatible:
- with a MnoHub without maestrano/maestrano-hub#514 ?
- with impac-angular?
Could you rename the PR to include the JIRA number as well as mention in the description the PRs on other projects?
Thanks
|
Also, are we missing specs here? |
xaun
changed the title
|
Linked PRs: |
|
@ouranos can you please re-review. The "backward compatiblity fix" for mnoe is a bit strange, when mno-hub is without the changes is maestrano-hub#515, mnoe kpi template errors with |
| it "creates kpi alerts" do | ||
| subject | ||
| expect(assigns(:kpi).alerts).to eq([alert]) | ||
| expect(response.code).to eq('200') |
There was a problem hiding this comment.
expect(response).to have_http_status(:ok)
| end | ||
| end | ||
|
|
||
| it { subject; expect(response.code).to eq('200') } |
There was a problem hiding this comment.
it { is_expected.to have_http_status(:ok) }
…anding-pages Public Pages - fix redirect logic
@cesar-tonnoir please review. Marked WIP as the #update & #delete actions are not validated as still working / updated.