Use price instead of price_tag #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ouranos Could you please code review ? |
| # Format a money object | ||
| def money(m) | ||
| "#{m.format(symbol: false)} #{m.currency_as_string}" | ||
| end |
There was a problem hiding this comment.
Why not just m.format? Is it to have the currency after the amount?
There was a problem hiding this comment.
m.format is giving something like $ 8, that is ambiguous.
There was a problem hiding this comment.
Ah got it, currency_as_string will give USD / AUD
|
Happy with this as long as @alachaum is happy with maestrano/Maestrano#1594 :) |
aluqueGH
pushed a commit
to aluqueGH/mno-enterprise
that referenced
this pull request
Jul 10, 2018
[IMPAC-308][WES-29] Fix impac widget loading issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think price should be send as a hash instead of a formatted string (because some information is lost, for example $12 can be 12 USD or 12 AUD)
See PR: https://github.com/maestrano/Maestrano/pull/1594