[MNOE-570] Storing the time of agreement to TOS #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 18, 2017 15:46
The time of agreement of TOS is stored in user[:metadata][tos_accepted_at] It is then used in the /confirmation to create (or not) the TOS checkbox.
ouranos
reviewed
Aug 21, 2017
| end | ||
| end | ||
|
|
||
| @@ -92,6 +92,9 @@ def finalize | |||
| end | |||
|
|
|||
| if resource.errors.empty? | |||
| if params[:tos] | |||
There was a problem hiding this comment.
Should you test params[:tos] == "accept"?
There was a problem hiding this comment.
The form can be submitted only when the TOS are accepted so it souldn't be required.
However, checking the exact string will improve clarity at no cost, I'm adding it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time of agreement of TOS is stored in user[:metadata][tos_accepted_at]
It is then used in the /confirmation to create (or not) the TOS checkbox.
@ouranos