Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bugs in the staff page and added improvments #46

Merged
merged 4 commits into from
Jul 6, 2016
Merged

Fixed bugs in the staff page and added improvments #46

merged 4 commits into from
Jul 6, 2016

Conversation

clemoberti
Copy link
Contributor

@clemoberti clemoberti commented Jul 5, 2016 •
edited
Loading

Bugs Fix

  • I fixed a bug stopping the page to reload when an action was done on a staff (update, delete, add).
  • Sends an invitation email when a staff is added so that he connects.

Improvements

  • Stopped non admin "admin" to access the staff page.

To Do

  • Make sure that the back-end stops staff to change admin_role.
  • Brings a new staff straight away to the admin platform and not to the enterprise dashboard..

ouranos
ouranos reviewed Jul 6, 2016
View reviewed changes
frontend-admin/src/app/components/mnoe-api/admin/current-user.svc.coffee
return userPromise if userPromise?
userPromise = MnoeApiSvc.one('current_user').get().then(
(response) ->

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/EmptyLines: Extra blank line detected.

@ouranos
Copy link
Contributor

ouranos commented Jul 6, 2016

Created MNOE-106 for the TODO item

@ouranos ouranos merged commit b8917bd into maestrano:master Jul 6, 2016
@ouranos ouranos added the bug label Jul 6, 2016
@clemoberti clemoberti deleted the bugFix/staff-page branch July 7, 2016 00:34
aluqueGH pushed a commit to aluqueGH/mno-enterprise that referenced this pull request Jul 10, 2018
@alexnoox
Merge pull request maestrano#46 from alexnoox/bugfixes
36c8835 
Bugfixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clemoberti @ouranos