Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNOE-106] Admin Panel Improvments #50

Closed

Conversation

claire00
Copy link
Contributor

No description provided.

@ouranos
Copy link
Contributor

ouranos commented Jul 19, 2016

@alexnoox Can you have a look at the Angular part?
I'm looking at the ruby and fixing the specs.

url = MnoEnterprise.router.dashboard_path || main_app.root_url
return (return_to_url(resource) || previous_url || url)
default_url = if resource.respond_to?(:admin_role) && resource.admin_role.present?
'/admin/'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ouranos: Can we use something like MnoEnterprise.router.admin_path?

@alexnoox
Copy link
Contributor

LGTM

@ouranos
Copy link
Contributor

ouranos commented Jul 20, 2016

@claire00 I've added the specs in 777dc88 and pushed to feature/admin_panel_improvement, update your local branch (git pull upstream feature/admin_panel_improvement) and have a look for your information.

Could you also add @alexnoox suggestion?

Thanks

@ouranos
Copy link
Contributor

ouranos commented Jul 22, 2016

Closing in favor of #54 to merge in 3.1 branch

@ouranos ouranos closed this Jul 22, 2016
aluqueGH pushed a commit to aluqueGH/mno-enterprise that referenced this pull request Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants