[MNOE-819] Update error handling when inviting user to organization #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase and open the PR against |
adamaziz15
force-pushed
the
bug/819-duplicate-invites
branch
from
67f0cf2 to
68b9bfc
Compare
adamaziz15
force-pushed
the
bug/819-duplicate-invites
branch
from
68b9bfc to
1dc62fe
Compare
|
@ouranos Updated to branch 3.3 |
ouranos
requested changes
Sep 5, 2018
| @@ -73,14 +73,19 @@ def invite_member | |||
| user = MnoEnterprise::User.find_by(email: user_params[:email]) || create_unconfirmed_user(user_params) | |||
|
|
|||
| # Create the invitation | |||
| invite = @organization.org_invites.create( | |||
| invite = MnoEnterprise::OrgInvite.create( | |||
| @@ -157,7 +157,7 @@ def partial_hash_for_arrears(arrear) | |||
| # Track the api call | |||
| @api_call = false | |||
| stub = -> { @api_call = true; from_api(org_invite) } | |||
| api_stub_for(post: "/organizations/#{organization.id}/org_invites", response: stub) | |||
| api_stub_for(post: "/org_invites", response: stub) | |||
There was a problem hiding this comment.
We need a spec for when the invitation is not saved.
I think persisted? is just checking the id so you can have a stub without id for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ouranos Ready for review. Leaving comments in JIRA.