Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNOE-137] Add Her middleware to handle errors #70

Merged
merged 1 commit into from
Aug 29, 2016

Conversation

ouranos
Copy link
Contributor

@ouranos ouranos commented Aug 26, 2016

Handle connection and server errors

Mnoe api call will now raise Faraday::Error::ConnectionFailed or Faraday::Error::ClientError instead of returning nil

When the call is valid but the resource is not found it'll still return nil to keep the same behavior.

Handle connection and server errors
@ouranos
Copy link
Contributor Author

ouranos commented Aug 26, 2016

@alachaum FYI

@BrunoChauvet
Copy link
Contributor

LGTM

@ouranos ouranos merged commit 2d39b71 into maestrano:2.0 Aug 29, 2016
@ouranos ouranos deleted the feature/137-her-handle-errors branch August 29, 2016 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants