[MNOE-1126] Restrict access to specific ProductInstances for a given team #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAhsenArif
force-pushed
the
teams_with_product_instances
branch
3 times, most recently
from
2021448 to
94a9db5
Compare
yuritomanek
previously approved these changes
Jun 1, 2018
adamaziz15
reviewed
Jun 1, 2018
| @@ -1,4 +1,5 @@ | |||
| @all_apps ||= MnoEnterprise::App.all.to_a | |||
| @all_products ||= MnoEnterprise::Product.all.to_a | |||
There was a problem hiding this comment.
@yuritomanek @ouranos I'm wondering if it would be better to do this the way it is done for the admin view? Not sure if it would improve performance alot, but wouldn't it be more efficient to include 'product_instances.product' in the teams controller rather than fetching all products?
…ce instead of app instance
MAhsenArif
force-pushed
the
teams_with_product_instances
branch
from
94a9db5 to
90f6b3b
Compare
MAhsenArif
force-pushed
the
teams_with_product_instances
branch
from
90f6b3b to
20d4c5d
Compare
yuritomanek
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.