[MNOE-1287] Delisted apps #785
Conversation
adamaziz15
force-pushed
the
bug/1287-delisted-apps
branch
from
cc5dcdf to
b0a71a3
Compare
Update tenant config schema to include only active apps
adamaziz15
force-pushed
the
bug/1287-delisted-apps
branch
from
b0a71a3 to
8eca0d0
Compare
|
@ouranos Rebased on 4.0 |
| @@ -156,9 +156,9 @@ def self.update_locales_list! | |||
| # Populate the app list after fetching it from MnoHub | |||
| # TODO: replace with a Proc.call | |||
| def self.update_application_list! | |||
| available_app_nids = App.all.map(&:nid) | |||
| available_app_nids = App.where(active: true).map(&:nid) | |||
There was a problem hiding this comment.
Should we add a default scope to App?
I don't think mnoe should ever see inactive apps?
There was a problem hiding this comment.
Or it could be done on the hub side
There was a problem hiding this comment.
Makes sense, maybe best to add it as a filter at the resource level in hub?
There was a problem hiding this comment.
Yeah, should be by default I reckon?
The inactive apps shouldn't be exposed on the API. We only need them in the DevPlatformSync job to re-enable them if they get re-activated from the DevPlatform
adamaziz15
force-pushed
the
bug/1287-delisted-apps
branch
from
8eca0d0 to
c6b40f8
Compare
adamaziz15
force-pushed
the
bug/1287-delisted-apps
branch
from
c6b40f8 to
d266abc
Compare
Add temp workaround for travis bundler issue. To be removed once issue has been resolved.
|
@ouranos Updated specs, looks like they were failing due to updates in nokogiri or sanitize gems. Build was then failing due to bundler failures in travis caused by outdated rubygems. I've added a temp fix for this until it is fixed in travis (added |
Update tenant config schema to include only active apps