Various improvements to reduce traffic #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 7, 2016 20:21
Delay can now be set as a min/max pair. The next update will be scheduled at a random point between those two. A query is sent on init, and when the delay is hit, but the delay is rescheduled when a peer beats us to it. When a peer sends a query, we get to use that query's answers, and can save a whole bunch of bandwidth and cpu by not sending a query ourselves.
The typical situation will be a local network setup. Peers send a query on init, so its unlikely we're going to miss one.
Comparison is used to prevent peers from connecting to eachother. When this check fails, an additional mdns answer was broadcast to invite the peer to connect. This usually results in a flurry of spurious answers in even a small swarm. In addition, it's rarely useful, because everyone responds to a query anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some changes to reduce MDNS traffic between peers (and thus also reduce CPU load).
I don't believe the changes up to and including 7b6108e can have adverse effects, but while 8452cb8 and 4807db4 improve things for my specific use-case, it felt like there may have been reasons for the old ways.
Some background: I'm using this library as a discovery mechanism for a microservices project. Most services actually run on the same machine (a Raspberry Pi 3), sometimes parts run on my regular workstation while I develop them. So all communication is on a fairly reliable local network.