fix: 🐛 Updated levelup version to 4.2.0 fixing audit #21
Conversation
|
@mafintosh please merge this and create an updated release |
|
I would like to request for a change, if that's okay. There is another vulnerability in
|
|
@srepollock This PR is incomplete. There have been breaking changes between levelup 0.x and 4 you'll need to account for. |
|
@mafintosh, have you had a chance to look at this yet? It would help us out a lot if this were fixed. |
| var fs = require('level-filesystem'); | ||
|
|
||
| var db = levelup('level-filesystem', {db:leveljs}); | ||
| var db = levelup(leveldown('level-filesystem'), {db:leveljs}); |
There was a problem hiding this comment.
@vweevers I've updated to use the leveldown system. I ran with node index.js example.js and it created a new file with some logs in the main project directory. They had .log files and I don't know the exact contents as they were written in buffered data. I believe this may be a fix, but request a review
|
I don’t have any time to review this. If someone wants to take it over let me know. |
|
@mafintosh user @lcsvcn has approved this and I addressed the issues @Vehmloewff commented on. Is there any more reason stopping this from being merged in? |
|
I apologize and would like to update this thread for the sake of @trevorblades . I have accidentally deleted the GitHub repo referenced in the PR here. I have recreated the repo and made the necessary changes here. I will have a release set up as well to pull from NPM, but I would suggest that this PR get some movement. If because I deleted the repo there is no way to merge in this PR, please @ me here and I can submit a new one with the new repo. Cheers |
|
@srepollock github maintains the code changes of deleted repos, thankfully. In the past it would've auto closed this PR but no more. |
|
Thanks for restoring that repo @srepollock! |
|
Any updates? |
|
Could someone teach me how to use @srepollock's fixed version of the repo instead of this version? Seeing that this PR will not be merged anytime soon. |
|
@SamsonChoo |
|
Hi this appears to still be an open issue. Is there a way to move this along and get it resolved? Happy to help in anyway I can |
|
@penfold45 currently the solution is to fork and fix yourself or to use someone else's fix. The developer seems to be inactive on here at this time. |
Closes: #20